Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video panning #3

Open
wants to merge 25 commits into
base: mod
Choose a base branch
from
Open

Video panning #3

wants to merge 25 commits into from

Conversation

MIRIMIRIM
Copy link

@MIRIMIRIM MIRIMIRIM commented Feb 20, 2023

New:

  1. Panning: dragging with the middle mouse button
  2. Zoom: ctrl + scroll
  3. New Option: Video - Reset video pan

Known issues:

  • Wrong window size when loading video from rencent with detached video, black edges will appear on the left and right

Changes from:

  1. Add video panning Aegisub/Aegisub#207
  2. Add Video Panning Option  TypesettingTools/Aegisub#150
  3. https://github.com/arch1t3cht/Aegisub/tree/352e41f19bd113a8f5975aa65588797d9906aa56

moex3 and others added 25 commits February 20, 2023 10:38
Crosshair drawing is broken when videoAr != displayAr
I'm not sure about that scale_factor, i don't know how to test that
with a "good enough" implementation
The preview window would change in width, when the video was being zoomed.
Possibly, because on windows, zooming only calls UpdateSize once, but on
linux, it gets called multiple, like 8 times.
Rounding fixed it.
I'm not entirely sure, that this is how it's supposed to be added.
This requires editing the already existing hotkey.json file (shows path
in log, if it exists).
Should this also be added to hotkey.cpp?
This reverts commit 3d525d9.
The default hotkey is not required. People can just add a custom one
from the hotkey settings if they want this.
Do this by partially reverting the changes to UpdateSize in favor of
just multiplying by videoZoomValue *after* setting all the window sizes.
It's probably stable enough at this point, and hiding it behind an
option just creates more confusion than it prevents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants